]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
extensions-app: Add tooltips to icon-only buttons from ExtensionRow
authorAutomeris naranja <104251-automerisnaranja@users.noreply.gitlab.gnome.org>
Wed, 30 Oct 2024 18:41:32 +0000 (15:41 -0300)
committerFlorian Müllner <fmuellner@gnome.org>
Sat, 23 Nov 2024 12:15:47 +0000 (13:15 +0100)
This improves the recognizability of these buttons.

Also, remove the button a11y labels, as Orca
tooltips are also read by Orca.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3529>
(cherry picked from commit 8a80dbec9eb1d7c49fccd0cd0e0131e7ba85d468)

subprojects/extensions-app/data/ui/extension-row.ui

index db7bb79df582856b077f715029fc0288b8fa89a4..c8364be490f92be32e57580bfe00b17fa772989b 100644 (file)
@@ -10,6 +10,7 @@
     </binding>
     <child type="suffix">
       <object class="GtkMenuButton" id="errorButton">
+        <property name="tooltip-text" translatable="yes">Error Details</property>
         <property name="valign">center</property>
         <property name="has-frame">false</property>
         <property name="icon-name">dialog-error-symbolic</property>
@@ -18,9 +19,6 @@
             <lookup name="extension" type="ExtensionRow"/>
           </lookup>
         </binding>
-        <accessibility>
-          <property name="label" translatable="yes">Error Details</property>
-        </accessibility>
         <property name="popover">
           <object class="GtkPopover" id="errorPopover">
             <property name="child">
@@ -50,6 +48,7 @@
     </child>
     <child type="suffix">
       <object class="GtkMenuButton" id="updatesButton">
+        <property name="tooltip-text" translatable="yes">Updates Details</property>
         <property name="valign">center</property>
         <property name="has-frame">false</property>
         <property name="icon-name">software-update-available-symbolic</property>
@@ -58,9 +57,6 @@
             <lookup name="extension" type="ExtensionRow"/>
           </lookup>
         </binding>
-        <accessibility>
-          <property name="label" translatable="yes">Updates Details</property>
-        </accessibility>
         <property name="popover">
           <object class="GtkPopover" id="updatesPopover">
             <property name="child">